🌱 Add support for v1beta2 conditions to patch helper#11150
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Sep 19, 2024
Merged
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
fabriziopandini
force-pushed
the
v1beta2-conditions-patch-helper
branch
4 times, most recently
from
f821534 to
d8ea122
Compare
sbueringer
changed the title
59 tasks
chrischdi
reviewed
Sep 12, 2024
sbueringer
reviewed
Sep 13, 2024
fabriziopandini
force-pushed
the
v1beta2-conditions-patch-helper
branch
from
d8ea122 to
e257b59
Compare
fabriziopandini
changed the title
sbueringer
reviewed
Sep 16, 2024
Member
sbueringer
left a comment
sbueringer
left a comment
There was a problem hiding this comment.
One round of review just for the delta
sbueringer
reviewed
Sep 16, 2024
chrischdi
reviewed
Sep 16, 2024
fabriziopandini
force-pushed
the
v1beta2-conditions-patch-helper
branch
from
e257b59 to
1a879d1
Compare
chrischdi
reviewed
Sep 17, 2024
fabriziopandini
force-pushed
the
v1beta2-conditions-patch-helper
branch
from
1a879d1 to
6be41b9
Compare
fabriziopandini
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
sbueringer
reviewed
Sep 17, 2024
sbueringer
added
the
tide/merge-method-squash
sbueringer
reviewed
Sep 19, 2024
fabriziopandini
force-pushed
the
v1beta2-conditions-patch-helper
branch
from
3aaa06e to
7a55bc4
Compare
Member
|
Thank you very much! Really nice work :) /lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 2381275627534d37eb8bfef487402a353fbaad75 |
k8s-ci-robot
added
the
approved
Member
|
/test pull-cluster-api-e2e-main (let's override if only the MP flake occurs) |
Member
|
/approve |
Member
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fabriziopandini
removed
the
tide/merge-method-squash
Member
Author
|
/test pull-cluster-api-e2e-main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for metav1 conditions (that will be used in v1beta2 types) to patch helper
Please do not review (it depends on
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Rif #11105
/area util