Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update dev observability stack to latest versions #11905

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

irapandey
Copy link
Contributor

What this PR does / why we need it:

This PR updates dev observability stack to latest versions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
#11881

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @irapandey. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@irapandey
Copy link
Contributor Author

Hey @sbueringer
Can you take a look here - Thanks 😄

@chrischdi
Copy link
Member

/ok-to-test
/area devtools

Question: did you do a quick check by using tilt up including all of them and see if they start up and provide some data? :-)

@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-area PR is missing an area label labels Feb 27, 2025
@irapandey
Copy link
Contributor Author

Question: did you do a quick check by using tilt up including all of them and see if they start up and provide some data? :-)

Hey - I had some trouble with the docker daemon in my system - I shall try the tilt up on a VM today

@irapandey
Copy link
Contributor Author

irapandey commented Mar 2, 2025

Everything looks good while checking using tilt up
Screenshot 2025-03-02 at 5 06 36 PM

Screenshot 2025-03-03 at 11 08 22 AM

@chrischdi
Copy link
Member

Note: besides the above change required:

  • I tested tilt with all addons enabled, also checked grafana dashboards and if loki works

@irapandey irapandey force-pushed the dev_obs_stack_update branch from b1924c4 to ea00c10 Compare March 6, 2025 05:17
Copy link

linux-foundation-easycla bot commented Mar 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2025
@irapandey
Copy link
Contributor Author

Looks like my CLA expired - let me renew it 🙃

@sbueringer
Copy link
Member

/lgtm

/assign @chrischdi

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aa18f5f0259494db69638bf47eb57d82c342abc3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 7, 2025
@irapandey irapandey requested a review from chrischdi March 7, 2025 04:58
@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 445a0c7 into kubernetes-sigs:main Mar 7, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants