-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Added test cases for list.go and github.go #11937
base: main
Are you sure you want to change the base?
🌱 Added test cases for list.go and github.go #11937
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @irapandey. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey @chandankumar4 - Can you take a look here |
/ok-to-test |
Please take a look at the linter findings. As soon as they got fixed I'd take a look at this PR :-) |
e246d5c
to
6b3dea8
Compare
6b3dea8
to
8b3ece5
Compare
/re-test |
Hey @chrischdi I think the lint task failed due to some error in setup - can we have this re-run so you can review it? Thanks 😄 |
👍 Triggered a rerun. |
What this PR does / why we need it:
This PR adds unit tests for release note generator to add more coverage to non-covered functions
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
#11368
/area testing
