Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 🌱 test-mdlink-check #12040

Open
wants to merge 1 commit into
base: release-1.10
Choose a base branch
from
Open

[WIP] 🌱 test-mdlink-check #12040

wants to merge 1 commit into from
+2 −2

Conversation

chrischdi
Copy link
Member

DO NOT REVIEW

only testing if mdlink check works since merging:

@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 28, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2025
@chrischdi chrischdi force-pushed the pr-test-mdlink-1-10 branch from fab85a3 to 653a763 Compare March 28, 2025 10:06
@chrischdi chrischdi changed the base branch from release-1.10 to release-1.9 March 28, 2025 10:12
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 28, 2025
@chrischdi chrischdi force-pushed the pr-test-mdlink-1-10 branch from 653a763 to 9585168 Compare March 28, 2025 10:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 28, 2025
@chrischdi chrischdi changed the base branch from release-1.9 to release-1.10 March 28, 2025 10:13
@chrischdi chrischdi force-pushed the pr-test-mdlink-1-10 branch from 9585168 to c494f4c Compare March 28, 2025 10:14
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrischdi. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2025
@chrischdi
Copy link
Member Author

Note: debugged this:

The current version of the markdown link check action is broken.

It needs a bump to markdown link check (the npm dependency) to 3.13.7 at
https://github.com/gaurav-nelson/github-action-markdown-link-check/blob/master/entrypoint.sh#L11

And a new release of the GH action

@Okabe-Junya
Copy link
Member

JFYI: I opened the PR to bump - https://github.com/gaurav-nelson/github-action-markdown-link-check/pull/205/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@vincepri vincepri Awaiting requested review from vincepri

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@chrischdi @k8s-ci-robot @Okabe-Junya