Skip to content

⚠️ Add v1beta2 API for ExtensionConfig #12197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

⚠️ Add v1beta2 API for ExtensionConfig #12197

wants to merge 11 commits into from

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Adds v1beta2 ExtensionConfig

Keeps using v1beta1 conditions for v1alpha1

Keeps lifecyclehooks on v1alpha1

Part of:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from elmiko and JoelSpeed May 13, 2025 09:47
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 13, 2025
@chrischdi chrischdi mentioned this pull request May 13, 2025
Open
73 tasks
JoelSpeed
JoelSpeed reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly like a copy/paste of the existing types and updating to the v1beta2 conditions. I left a couple of comments about API things I noticed but I'm not expecting those to be fixed here.

Are there known changes we want to make for v1beta2 for this API?

exp/runtime/api/v1beta2/extensionconfig_types.go

// ClientConfig contains the information to make a client
// connection with an Extension server.
type ClientConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClientConfig is required but does not have any required fields within it, so I could just created something with

clientConfig: {}

What would that mean? Is that valid? Should this actually be optional/have a required field/have a MinProperties?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this is the only potential change (?), we could consider doing it here. Otherwise we should add it to:

@sbueringer @fabriziopandini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lets track it and tackle separately. We could probably do a more thorough API review of these types to be honest

Copy link
Member

@fabriziopandini fabriziopandini May 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to make a thorough API review
In this case, exactly one of url or service must be specified so clientConfig cannot be nil

@chrischdi chrischdi changed the title [WIP] ⚠️ Add v1beta2 API for ExtensionConfig ⚠️ Add v1beta2 API for ExtensionConfig May 13, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 13, 2025
@chrischdi chrischdi force-pushed the pr-extensionconfig-v1beta2 branch from 3cb61c4 to 95f2916 Compare May 15, 2025 07:08
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@JoelSpeed
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ebc5a11324105549987e1c506689a8a6ff7ea54

fabriziopandini
fabriziopandini reviewed May 15, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see ExtensionConfig making progress, thanks!
only one nit from my side

exp/runtime/api/v1beta2/extensionconfig_types.go Outdated
// ExtensionConfigV1Beta1DeprecatedStatus groups all the status fields that are deprecated and will be removed when support for v1beta1 will be dropped.
// See https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md for more context.
type ExtensionConfigV1Beta1DeprecatedStatus struct {
// conditions defines current service state of the Machine.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// conditions defines current service state of the Machine.
// conditions defines current service state of the ExtensionConfig.

@chrischdi chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 16, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025
@k8s-ci-robot k8s-ci-robot requested a review from JoelSpeed May 16, 2025 05:47
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-verify-main b88fd90 link true /test pull-cluster-api-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels
area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @JoelSpeed @fabriziopandini