Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vulns/CVE-2020-10749.json #6

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Update vulns/CVE-2020-10749.json #6

merged 3 commits into from
Jul 10, 2024
+2 −2

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jul 9, 2024

This PR updates vulns/CVE-2020-10749.json

@k8s-ci-robot k8s-ci-robot requested a review from IanColdwater July 9, 2024 11:16
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from PushkarJ July 9, 2024 11:16
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2024
@chen-keinan
Copy link
Member

chen-keinan commented Jul 9, 2024 •
edited
Loading

this CVE has been reviewed already we only need to update the modified field, so collector will not pick it up again
@knqyf263 wdyt?

@chen-keinan chen-keinan requested a review from knqyf263 July 9, 2024 11:26
knqyf263
knqyf263 reviewed Jul 9, 2024
View reviewed changes
@chen-keinan
chore: update modified date
2ba1fa2 
Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan chen-keinan requested a review from knqyf263 July 9, 2024 15:35
knqyf263
knqyf263 reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@knqyf263 knqyf263 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lines seem to be updated now. Is it because two spaces vs four spaces? Can we not change other lines than modified?

@knqyf263
update "modified" only
6e302da 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@knqyf263
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2024
@chen-keinan
Copy link
Member

/lgtm

@chen-keinan
Copy link
Member

/approve

@chen-keinan chen-keinan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chen-keinan, github-actions[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 61910a9 into main Jul 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263

@chen-keinan chen-keinan

@IanColdwater IanColdwater

@PushkarJ PushkarJ

Assignees

@knqyf263 knqyf263

@chen-keinan chen-keinan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chen-keinan @knqyf263 @k8s-ci-robot @actions-user