-
Notifications
You must be signed in to change notification settings - Fork 194
SLO Aware Routing Plugins Only #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SLO Aware Routing Plugins Only #1849
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @BenjaminBraunDev. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg/epp/scheduling/framework/plugins/multi/slo_aware_router/latencypredictor_helper.go
Outdated
Show resolved
Hide resolved
pkg/epp/scheduling/framework/plugins/multi/slo_aware_router/latencypredictor_helper.go
Show resolved
Hide resolved
pkg/epp/scheduling/framework/plugins/multi/slo_aware_router/latencypredictor_helper.go
Show resolved
Hide resolved
pkg/epp/scheduling/framework/plugins/multi/slo_aware_router/latencypredictor_helper.go
Outdated
Show resolved
Hide resolved
|
I think a lot of these helper functions are doing way too much in a single func, and we should unexport many of these helper funcs since they should all be in the same package. Additionally I would like Jeff to take a look to see if we can emit metrics from a plugin without having to register them, as I don't want to set a precedent that metrics arent generalizable and pluggable. /approve Will LGTM after Jeff responds & the helper funcs are unexported. TY! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenjaminBraunDev, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agree with this. I will unexport pretty much everything here as it's an artifact of when latency predictor wasn't in the plugin package. The helper functions can be broken down further. I will work on that. |
SG, I don't consider that a blocker for this specific PR, but I think will be important for long term maintenance. So, up to you if you want to include in this PR or a follow up. |
|
/ok-to-test |
…er metrics for prediction
…lk prediction, add bulk prediction tests
|
Reached out to @JeffLuoo regarding metric consolidation. Waiting on response there, but everything else should be ready to merge. |
This is PR 2/3 for the SLO aware routing, containing all the new plugins required for scoring/routing, tracking, and profile picking (as well as their metrics, required for them to compile). Due to the size of the change, we aren't including integration in this PR, this is solely the addition of plugin files, with integration into EPP coming in PR 3. (Cut from full PR #1839)
The plugins, once implemented include the following features:
Design and details: #1323
Does this PR introduce a user-facing change?: