-
Notifications
You must be signed in to change notification settings - Fork 208
Add Prefill Heavy E2E Test to Github Actions #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @rlakhtakia. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/ok-to-test |
|
@rlakhtakia How is this workflow launched? I hope it isn't launched on every PR, I saw a timeout of 7200 (seconds I assume). |
It won't be auto triggered on every PR, but will require a comment /run-gke-prefill-heavy. We can make it more strict so that only owners and members can trigger the command to ensure its not overused. |
Given this is currently running on a GCP project, can we limit the access to people who have access to that project. This is just to make sure whoever triggers the workflow can coordinate the resources in the project given the resource scarcity. Can we also update the benchmark public doc on who and how to trigger these tests? |
a427096 to
b4d25a0
Compare
|
@liu-cong Updated to only allow maintainers, owners and anyone authorized from the workflow file to trigger the command from a PR comment or manually through the github actions tab. Docs have also been updated to reflect how to trigger these tests. Note: Even if a collaborator were to create a branch and add their name to the list, when setting up these workflows, those users will still have to pass in the correct secrets to use the GCP project. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, rlakhtakia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area conformance-test
What this PR does / why we need it:
Add new github actions e2e test to validate and benchmark anything requiring the use of prefill heavy workloads.
Does this PR introduce a user-facing change?: