removed ctx from datastore struct

[nirrozenbaum]

instead added ctx to one function that required it which is more aligned with best practices.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nirrozenbaum
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	4bb3be3
🔍 Latest deploy log	https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67ed2bdb531509000887d092
😎 Deploy Preview	https://deploy-preview-641--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ahg-g]

The existing logic is intentional. We need the parent context because it is used to start a metrics probing goroutine that should continue to live beyond the life of the reconcile event that triggered its creation.

/hold

[nirrozenbaum]

can you point me to the code you’re referring to?
reconcile event also gets context (in controller-runtime) and that can be used in a new go routine.
in general, best practice for context usage is to usually propagate the context between functions rather than saving in struct.

[ahg-g]

My point is that the context that is created as part of the pod reconcile even is short lived, it is live span is related to that of the event. The metrics probing thread on the other hand is supposed to live longer than the pod reconcile event that triggered the creation of the metrics probing thread.