-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Disk Topology Feature #1983
base: master
Are you sure you want to change the base?
Introduce Disk Topology Feature #1983
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: julianKatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @julianKatz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a23f433
to
d73f071
Compare
d73f071
to
c0f81d1
Compare
c0f81d1
to
b2bf395
Compare
d8497dd
to
baf7abf
Compare
baf7abf
to
df19d2a
Compare
52b8108
to
2afcb89
Compare
/assign @tonyzhc |
64a3b17
to
8f75d1b
Compare
8f75d1b
to
57c3e4a
Compare
2d067b5
to
0122cb5
Compare
we will rely solely on the binary flag to decide when to apply the labels
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces a new, flag-gated feature: Disk Topology. Disk Topology has two fundamental pieces:
More labels in
NodeGetInfo
Historically, only the
topology.gke.io/zone
label would be returned as a Topology inNodeGetInfo
. GKE will be implementing a host of new labels that are 1:1 with each of its disk products (both legacy Persistent Disk and new Hyperdisk products). This PR adds support for those labels inNodeGetInfo
.Adding a disk type label in
CreateVolumeResponse.Topologies
based onparameters.type
With the addition of these new disk type labels to nodes, we can include disk type labels in workload scheduling. To affect that, those same labels must be included in a PersistentVolume's
NodeAffinity
clause. This PR includes a disk support label consistent with thetype
specified in the StorageClass in each of the Topology segments included inCreateVolumeResponse
. External Provisioner will then read these and add them as NodeAffinity requirements on the PV.The feature is gated on the newly introduced
--disk-topology=[true|false]
flag, which is disabled by default.Special notes for your reviewer: None.
Does this PR introduce a user-facing change?:
Yes, users can set the flag to
true
and enable the new functionality.