Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump netobserv v0.0.6 #4400

Closed
wants to merge 1 commit into from
Closed

Conversation

jotak
Copy link

@jotak jotak commented Feb 11, 2025

No description provided.

Signed-off-by: Joel Takvorian <[email protected]>
@ahmetb
Copy link
Member

ahmetb commented Feb 11, 2025

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request seems to be a straightforward version bump. I'll go ahead and accept it. 👍 Cheers.

/lgtm
/approve

/kind plugin-update

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented Feb 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jotak / name: Joel Takvorian (e6b25e2)

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/plugin-update Version or manifest updates for existing plugins labels Feb 11, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @jotak!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 11, 2025
@jotak
Copy link
Author

jotak commented Feb 11, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

@jotak: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jotak
Copy link
Author

jotak commented Feb 11, 2025

Hi @chriskim06 ,
My plugin tgz wasn't available when I opened the PR, hence the validation check failing, I think it should pass now if we can restart it

@chriskim06
Copy link
Member

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 11, 2025
@chriskim06
Copy link
Member

/retest

@ahmetb
Copy link
Member

ahmetb commented Feb 12, 2025

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@jotak
Copy link
Author

jotak commented Feb 12, 2025

@ahmetb thanks for the info, yes I just saw that yesterday, we're going to do that.

I'm closing this PR because we've identified an issue with that release, so we'll fix it and reopen another PR (or implement the automated workflow)

@jotak jotak closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants