allow repeated --test-overrides & --test-configs to work for cl2 #303
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
pkg/testers/clusterloader2/cl2.go
Outdated
| EnablePrometheusServer bool `desc:"Whether to set-up the prometheus server in the cluster."` | ||
| PrometheusPvcStorageClass string `desc:"Storage class used with prometheus persistent volume claim."` | ||
| ExtraArgs string `flag:"~extra-args" desc:"Additional arguments supported by clusterloader2 (https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/cmd/clusterloader.go)."` | ||
| Suites string `desc:"List of standard scale testing suites e.g. load, density"` |
There was a problem hiding this comment.
Is this supposed to be a slice?
There was a problem hiding this comment.
Yes, let me change that too. I'm not using the specific flag so I missed it
k8s-ci-robot
added
the
lgtm
|
@upodroid: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
--test-config and --test-overrides are expecting comma-separated strings instead of a list of flags. No one else is using nkubetest2+clusterloader2 yet, so it should be safe.
Related to kubernetes/kops#17671
@hakman