allow using helmChart without repo URL

[aarnaud]

This fix allows using the Helm Chart with the Chart in the repo. the regression was introduced by #4999

That I don't know why require a repo to use the version.

So this fix allows us to use multiple versions of charts that are stored in the chartHome:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

helmGlobals:
  chartHome: mycharts

helmCharts:
  - name: harbor
    releaseName: harbor
    version: 1.16.0

[k8s-ci-robot]

Welcome @aarnaud!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @aarnaud. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aarnaud
Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MrFreezeex]

Not a kustomize reviewer but to me it look like that those conditions were meant to be checking for a non empty chart name/name instead of an empty repo as it is always the chart name and the version used after those condition. I haven't checked the rest of the code related to helm in kustomize lately though so maybe there are other checks for that too and checking for empty name would be not necessary here 🤷‍♂️

/ok-to-test

[varshaprasad96]

The change seems reasonable if the chart already exists locally directly in the chart home. We may not need repo for that and it should be allowed (

kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go

Line 281 in 880a7a0

if path, exists := p.chartExistsLocally(); !exists {

)
/ok-to-test
/lgtm

[k8s-ci-robot]

@aarnaud: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kustomize-presubmit-master	7887346	link	true	/test kustomize-presubmit-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.