Skip to content

apis: conformance: add traffic distribution and internal traffic policies fields #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

apis: conformance: add traffic distribution and internal traffic policies fields #131

wants to merge 2 commits into from
+87 −0

Conversation

MrFreezeex
Copy link
Member

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex
Once this PR has been reviewed and has the lgtm label, please assign skitt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2025
@MrFreezeex MrFreezeex force-pushed the traffic-distribution branch 2 times, most recently from 0dada84 to 0afcfec Compare October 2, 2025 12:02
@MrFreezeex MrFreezeex changed the title apis: add traffic distribution and internal traffic policies fields apis: conformance: add traffic distribution and internal traffic policies fields Oct 2, 2025
@skitt
Copy link
Member

skitt commented Oct 7, 2025

/sig multicluster

@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 7, 2025
@MrFreezeex MrFreezeex force-pushed the traffic-distribution branch from 0afcfec to 5b86030 Compare October 10, 2025 09:18
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
mikemorris
mikemorris reviewed Oct 14, 2025
View reviewed changes
conformance/service_import.go

Context("", func() {
BeforeEach(func() {
t.helloService.Spec.TrafficDistribution = ptr.To(corev1.ServiceTrafficDistributionPreferClose)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a heads up, this API is in a bit of flux for Service, see KEP-3015 and kubernetes/kubernetes#130844

Copy link
Member Author

@MrFreezeex MrFreezeex Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine no? It's already graduating to stable in kube 1.35 and was already beta/enabled by default in kube 1.34.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is graduating, but also being replaced by PreferSameZone and PreferSameNode is being added for more explicit semantics.

@lauralorenz lauralorenz mentioned this pull request Oct 14, 2025
Open
@lauralorenz
Copy link
Contributor

Triage note:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

@ryanzhang-oss ryanzhang-oss Awaiting requested review from ryanzhang-oss

1 more reviewer

@mikemorris mikemorris mikemorris left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MrFreezeex @k8s-ci-robot @skitt @lauralorenz @mikemorris