Add a diagram shows how metrics-server handles kubectl top pod request #1654
Conversation
…is/metrics.k8s.io/v1beta1/:
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
CatherineF-dev
changed the title
|
This is very nice :) |
|
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_metrics-server/1654/pull-metrics-server-verify/1920253007463714816 is been stuck something to do after golang ci update probably I will take a look but for now closing and reopening the PR will help |
|
/close |
|
@slashpai: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@slashpai: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/retest |
|
/assign @serathius |
|
@CatherineF-dev do you want to address the open comments here? Seems to be a nice documentation change to have in. |
|
ping @CatherineF-dev |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
@serathius needs a review again. |
|
@serathius, would you mind reviewing again when available? |
|
Can you squash the commits? /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
7 participants
See diagram at https://github.com/kubernetes-sigs/metrics-server/blob/d8993efbc4c82ba49335c4a513575cdc0f8a8fea/README.md
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #