-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using material design for other tables as well #379
base: main
Are you sure you want to change the base?
Using material design for other tables as well #379
Conversation
Hi @hector-vido. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -60,7 +60,7 @@ | |||
</aside> | |||
<article> | |||
<div class="table-container"> | |||
<table id="builds"> | |||
<table id="builds" class="mdl-data-table mdl-js-data-table mdl-shadow--2dp"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could, similarly to @smg247 prepare deployment with proposed changes for us to see the difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
It makes sense to have unified look. Please see attached deployment from @hector-vido. LGTM from me, but weather it will be merged or not, depends on taste :)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hector-vido, jmguzik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am not a fan of the smaller font size, I think the rest of the look is good though. Can we try out a preview with the font size reverting to the original? |
@hector-vido: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I appreciate the effort of setting up an example instance! I really like the hover effect and let's find a way how we can get it working. Some things we need to address (holding for these)
Some things that kinda bug me but I could live with them:
|
What do you thing about adding the "default" material style for tables - used on https://prow.k8s.io/command-help - for other tables as well?
This let the appearance more appealing and modern and also give a visual feedback on what line we are with the mouse - very helpful.
This also shrink the font a little, but the final result is good in my opinion.
As a reference for the future, this is the version without style:

This is the version with style and line feedback:
