Skip to content

Conversation

@johngmyers
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Upgrades controller-runtime as needed to fix CVE-2023-44487.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes CVE-2023-44487

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from aramase and ritazh October 8, 2025 04:33
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 8, 2025
@johngmyers
Copy link
Contributor Author

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Oct 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.03%. Comparing base (ac629c8) to head (9660438).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/secrets-store-csi-driver/main.go 0.00% 7 Missing ⚠️
pkg/metrics/prometheus_exporter.go 0.00% 2 Missing ⚠️
pkg/secrets-store/stats_reporter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
- Coverage   28.35%   27.03%   -1.33%     
==========================================
  Files          63       63              
  Lines        4535     3780     -755     
==========================================
- Hits         1286     1022     -264     
+ Misses       3124     2633     -491     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enj enj added this to SIG Auth Oct 8, 2025
@enj enj moved this to Subprojects - Needs Triage in SIG Auth Oct 8, 2025
@johngmyers
Copy link
Contributor Author

By the way, codecov is using the wrong base commit. It appears to be configured to use master branch, which no longer exists.

@aramase
Copy link
Member

aramase commented Nov 3, 2025

/triage accepted
/retitle chore: Upgrade controller-runtime to v0.18.7

@k8s-ci-robot k8s-ci-robot changed the title Upgrade controller-runtime to v0.18.7 chore: Upgrade controller-runtime to v0.18.7 Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2025
@github-project-automation github-project-automation bot moved this from Subprojects - Needs Triage to Changes Requested in SIG Auth Nov 3, 2025
@johngmyers johngmyers requested a review from aramase November 4, 2025 01:09
@johngmyers johngmyers requested a review from aramase November 5, 2025 22:40
@k8s-ci-robot
Copy link
Contributor

@johngmyers: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-csi-driver-image-scan 9660438 link false /test pull-secrets-store-csi-driver-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aramase
Copy link
Member

aramase commented Nov 5, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 5, 2025
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7b33761 into kubernetes-sigs:main Nov 5, 2025
23 of 25 checks passed
@github-project-automation github-project-automation bot moved this from Changes Requested to Closed / Done in SIG Auth Nov 5, 2025
@johngmyers johngmyers deleted the runtime-squashed branch November 5, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants