-
Notifications
You must be signed in to change notification settings - Fork 319
chore: Upgrade controller-runtime to v0.18.7 #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade controller-runtime to v0.18.7 #1938
Conversation
|
/area dependency |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
- Coverage 28.35% 27.03% -1.33%
==========================================
Files 63 63
Lines 4535 3780 -755
==========================================
- Hits 1286 1022 -264
+ Misses 3124 2633 -491
Partials 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
08be088 to
d409154
Compare
|
By the way, codecov is using the wrong base commit. It appears to be configured to use |
|
/triage accepted |
|
@johngmyers: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label tide/merge-method-squash |
aramase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Upgrades controller-runtime as needed to fix CVE-2023-44487.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes CVE-2023-44487
Special notes for your reviewer:
TODOs: