Skip to content

Fix flaky e2e tests: snapshot size/timeouts and concurrent pod creation race#4166

Open
sipriyaa wants to merge 1 commit into
kubernetes-sigs:masterfrom
sipriyaa:gc-code-fixes-block
Open

Fix flaky e2e tests: snapshot size/timeouts and concurrent pod creation race#4166
sipriyaa wants to merge 1 commit into
kubernetes-sigs:masterfrom
sipriyaa:gc-code-fixes-block

Conversation

@sipriyaa

Copy link
Copy Markdown
Contributor
  • Fix concurrent CnsNodeVmAttachment pod creation test racing its own shared context cancellation, which caused spurious AfterEach failures when the async pod's readiness wait outlived the It block.
  • Use actual PVC/snapshot restore sizes instead of hardcoded values, and extend VC reboot recovery and CNS volume deletion timeouts to reduce snapshot test flakiness.

Testing done:
InProgress

…on race

- Fix concurrent CnsNodeVmAttachment pod creation test racing its own
  shared context cancellation, which caused spurious AfterEach failures
  when the async pod's readiness wait outlived the It block.
- Use actual PVC/snapshot restore sizes instead of hardcoded values,
  and extend VC reboot recovery and CNS volume deletion timeouts to
  reduce snapshot test flakiness.
@kubernetes-prow
kubernetes-prow Bot requested a review from deepakkinni July 17, 2026 09:55
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested a review from kavyashree-r July 17, 2026 09:55
@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant