-
Notifications
You must be signed in to change notification settings - Fork 243
adjust tools/update_vendor.sh to use go.work, verify go.work and remove the symlink in vendor #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
adjust tools/update_vendor.sh to use go.work, verify go.work and remove the symlink in vendor #901
Conversation
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1e89f7a
to
b3cfee0
Compare
As side-effect this also removes the symlink in vendor used for providers, because go work tidy does not create it anymore.
/retest |
b3cfee0
to
2434bf2
Compare
I think this makes sense, we're working using go modules/workspaces properly, and is nicer than special casing a symlink! lgtm, but will wait to see what other maintainers think :) |
Seems like a step in the right direction as far as I'm concerned /assign @cheftako I think Walter will be interested in this one |
/lgtm |
As side-effect this also removes the symlink in vendor used for providers, because go work tidy does not create it anymore.
We were building cloud-provider-gcp in a hermetic environment which always tries to rebuild vendor in a clean way.
This resulted in a diff, because it would not have applied the symlink workaround for providers.
This PR would add
go.work
andgo.work.sum
and makes use ofgo work vendor
which results in not even vendoring the providers module.Also ensures that all modules are always tidied.
Question to the maintainers: If this makes sense I'm happy to address further comments / get this merged. Otherwise I'm also fine with closing this if it is not considered worth it.
cc @theobarberbany