Skip to content

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Sep 16, 2025

As side-effect this also removes the symlink in vendor used for providers, because go work tidy does not create it anymore.

We were building cloud-provider-gcp in a hermetic environment which always tries to rebuild vendor in a clean way.

This resulted in a diff, because it would not have applied the symlink workaround for providers.

This PR would add go.work and go.work.sum and makes use of go work vendor which results in not even vendoring the providers module.

Also ensures that all modules are always tidied.

Question to the maintainers: If this makes sense I'm happy to address further comments / get this merged. Otherwise I'm also fine with closing this if it is not considered worth it.

cc @theobarberbany

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrischdi
Once this PR has been reviewed and has the lgtm label, please assign vinayakankugoyal for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2025
@chrischdi chrischdi force-pushed the pr-remove-providers-symlink branch from 1e89f7a to b3cfee0 Compare September 19, 2025 13:43
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 19, 2025
As side-effect this also removes the symlink in vendor used for providers, because go work tidy does not create it anymore.
@chrischdi
Copy link
Member Author

/retest

@chrischdi chrischdi force-pushed the pr-remove-providers-symlink branch from b3cfee0 to 2434bf2 Compare September 22, 2025 15:21
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2025
@theobarberbany
Copy link
Contributor

I think this makes sense, we're working using go modules/workspaces properly, and is nicer than special casing a symlink!

lgtm, but will wait to see what other maintainers think :)

@JoelSpeed
Copy link

Seems like a step in the right direction as far as I'm concerned

/assign @cheftako

I think Walter will be interested in this one

@JoelSpeed
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants