Skip to content

Conversation

08volt
Copy link
Member

@08volt 08volt commented Oct 14, 2025

  • Refactor ensureExternalLoadBalancer and ensureInternalLoadBalancer functions to return additional resource URLs.
  • Update related tests to accommodate the new return values.
  • Introduce gce_serviceloadbalancerstatus.go for managing ServiceLoadBalancerStatus CRD, including creation, update, and equality checks.
  • Ensure proper handling of existing CRs and their specifications.
  • Enhance error handling and logging for better traceability.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz October 14, 2025 10:14
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 08volt
Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@08volt 08volt force-pushed the vservicelbstatus-crd branch 2 times, most recently from 9df00dd to d6e8591 Compare October 14, 2025 14:32
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 14, 2025
…lancer functions

- Refactor `ensureExternalLoadBalancer` and `ensureInternalLoadBalancer` functions to return additional resource URLs.
- Update related tests to accommodate the new return values.
- Introduce `gce_serviceloadbalancerstatus.go` for managing ServiceLoadBalancerStatus CRD, including creation, update, and equality checks.
- Ensure proper handling of existing CRs and their specifications.
- Enhance error handling and logging for better traceability.
@08volt 08volt force-pushed the vservicelbstatus-crd branch from d6e8591 to d6030be Compare October 15, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants