Skip to content

[docs] add more uses cases to node-selector service annotation #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2025
Merged

[docs] add more uses cases to node-selector service annotation #2869

merged 1 commit into from
Nov 13, 2025

Conversation

@kayrus
Copy link
Contributor

@kayrus kayrus commented Mar 26, 2025 •
edited
Loading

What this PR does / why we need it:

Add more context about the node-selector service annotation and how to use it in combination with the node.kubernetes.io/exclude-from-external-load-balancers node label.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

See also #2601

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from dulek and mdbooth March 26, 2025 14:22
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2025
@kayrus kayrus force-pushed the update-lbaas-docs branch from 6c04be3 to 1a93efd Compare March 26, 2025 14:24
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2025
@kayrus kayrus force-pushed the update-lbaas-docs branch from 1a93efd to c07acf1 Compare March 26, 2025 14:31
@kayrus kayrus marked this pull request as draft March 27, 2025 16:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2025
@kayrus kayrus mentioned this pull request May 21, 2025
Closed
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jun 25, 2025

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2025
@kayrus
Copy link
Contributor Author

kayrus commented Jun 25, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2025
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 23, 2025

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2025
@kayrus
Copy link
Contributor Author

kayrus commented Sep 24, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2025
@kayrus kayrus marked this pull request as ready for review November 11, 2025 15:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@kayrus
Copy link
Contributor Author

kayrus commented Nov 11, 2025

@stephenfin @zetaab
the node.kubernetes.io/exclude-from-external-load-balancers=false label is supported starting from k8s 1.34, the PR is ready to be merged.

@kayrus kayrus mentioned this pull request Nov 11, 2025
Open
@dulek
Copy link
Contributor

dulek commented Nov 13, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit ca5ac83 into kubernetes:master Nov 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulek dulek Awaiting requested review from dulek

@mdbooth mdbooth Awaiting requested review from mdbooth

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@dulek dulek

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kayrus @k8s-triage-robot @dulek @k8s-ci-robot