Skip to content

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Oct 8, 2025

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2025
@zetaab
Copy link
Member Author

zetaab commented Oct 8, 2025

cc @kayrus @stephenfin are we missing anything from the release? if yes, those should be added before this

@kayrus
Copy link
Contributor

kayrus commented Oct 8, 2025

@zetaab see #2864

@stephenfin
Copy link
Member

/lgtm
/approve
/hold

Let's try get #2864 in. Assuming that passes and is merged, please feel free to unhold this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@gouthampacha
Copy link
Contributor

i'd like two others: #2994 #2915 as well, if folks could spare some review cycles..

@stephenfin
Copy link
Member

#2864 is merged now. @gouthampacha it looks like there's a bit of discussion still needed on the other PRs. Given we're already a few weeks late, I'd be inclined to cut the release now and get those in shortly so they're well embedded for the 1.35 release.

@zetaab @kayrus feel free to remove the hold if you agree.

@kayrus
Copy link
Contributor

kayrus commented Oct 13, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@stephenfin
Copy link
Member

/test openstack-cloud-csi-cinder-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 9a6c890 into master Oct 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants