Skip to content

KEP-1326: update to reflect implementation#4638

Closed
sftim wants to merge 6 commits into
kubernetes:masterfrom
sftim:20240516_revise_1326
Closed

KEP-1326: update to reflect implementation#4638
sftim wants to merge 6 commits into
kubernetes:masterfrom
sftim:20240516_revise_1326

Conversation

@sftim
Copy link
Copy Markdown

@sftim sftim commented May 16, 2024

Fixes #1326

  • One-line PR description: Mark KEP as implemented

  • Issue link: Doc policies for third party content #1326

  • Other comments:
    This PR bundles several related changes that fall under the broad heading of “record the actual state for this KEP”

    We / I can split out any commit that should be reviewed separately.

/sig docs

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 16, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
@sftim sftim force-pushed the 20240516_revise_1326 branch from 4b9caa0 to eddd978 Compare May 16, 2024 00:37
Tim Bannister added 2 commits May 16, 2024 01:42
Add note about operating system
7e0fadf 
Kubernetes docs include some particulars about operating system
(obviously NOT part of Kubernetes); make it clear that this is a minimum
viable amount of detail. Minutiae, asides about how the operating system
works, and vendor opinions about good practice usually belong elsewhere.
Mark KEP as implemented
aa1255d 
The key changes that this KEP calls for have been made.
@sftim sftim force-pushed the 20240516_revise_1326 branch from eddd978 to aa1255d Compare May 16, 2024 00:42
divya-mohan0209
divya-mohan0209 reviewed May 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Thank you for this update, Tim :)

kikisdeliveryservice
kikisdeliveryservice approved these changes May 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divya-mohan0209 mind giving a formal lgtm, it doesn't seem to be recorded on the CL.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Aug 19, 2024

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2024
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Sep 18, 2024

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 18, 2024
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Oct 18, 2024

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 18, 2024

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@palnabarun palnabarun Awaiting requested review from palnabarun

+1 more reviewer

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doc policies for third party content

5 participants

@sftim @k8s-ci-robot @k8s-triage-robot @kikisdeliveryservice @divya-mohan0209