-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-1326: update KEP and mark implemented #5245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @lmktfy! |
Hi @lmktfy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
- "@cblecker" | ||
- "@derekwaynecarr" | ||
- "@dims" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are from Steering, and the policy itself has already been approved (and implemented).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmktfy could you add the appropriate reviewers/approvers for this?
1. Who decides when to include third-party content? | ||
* formally document a consensus on what types of third-party | ||
content are appropriate for inclusion in Kubernetes documentation | ||
* define consistent policies for how Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit.
We should consider explicitly stating that the scope of the policies mentioned in this point and the standards in the point below are specific to SIG Docs and the content it is responsible for. It might be implied, but I'd like to leave no room for misinterpretation later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor nit, but otherwise LGTM.
Other comments: