Skip to content

KEP-4427: Promote Relaxed DNS search string validation to GA #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

KEP-4427: Promote Relaxed DNS search string validation to GA #5352

merged 1 commit into from
May 30, 2025
+13 −3

Conversation

adrianmoisey
Copy link
Member

  • One-line PR description: Promote to GA for Kubernetes 1.34
  • Other comments: I think this is all that's needed to change, but I'm not confident. Is a PRR needed for GA?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2025
@adrianmoisey
Copy link
Member Author

Right, I need a PRR:

getting PRR approver for stable stage: the selected PRR milestone stage is not populate

@adrianmoisey
Copy link
Member Author

/assign jpbetz
(for PRR)

@jpbetz
Copy link
Contributor

jpbetz commented May 30, 2025

/approve
For PRR. Thanks for all the hard work on this one

@aojea
Copy link
Member

aojea commented May 30, 2025

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, aojea, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3a4c03f into kubernetes:master May 30, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeZappa87 MikeZappa87 Awaiting requested review from MikeZappa87

@thockin thockin Awaiting requested review from thockin

Assignees

@jpbetz jpbetz

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianmoisey @jpbetz @aojea @k8s-ci-robot