-
Notifications
You must be signed in to change notification settings - Fork 934
enable nested virt & set single process oom kill #8672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ran Plan for dir: Plan Error Show Output
|
machine_type = "c4-highmem-8-lssd" | ||
disk_size_gb = 100 | ||
disk_type = "hyperdisk-balanced" | ||
enable_nested_virtualization = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use case? Nested virt can have poor performance, create noise for neighbors, and we need to make sure the VMs are not leaked ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an example, trying to enable workflows like these in prow.
https://github.com/kubernetes/kops/blob/master/.github/workflows/e2e.yml
https://github.com/kubernetes/kops/actions/runs/18663330367/job/53208805245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, in kind we also use actions for this, which is mostly ~fine.
/lgtm |
New changes are detected. LGTM label has been removed. |
Ran Plan for dir: Show OutputTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_vmwareengine_network_peering.gvce_peering will be updated in-place
~ resource "google_vmwareengine_network_peering" "gvce_peering" {
~ export_custom_routes_with_public_ip = false -> true
id = "projects/k8s-infra-prow-build/locations/global/networkPeerings/peer-with-gcve-project"
~ import_custom_routes_with_public_ip = false -> true
name = "peer-with-gcve-project"
# (13 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Plan: 0 to add, 1 to change, 0 to destroy.
|
/hold cancel Successfully applied |
More immediate version of #8600
Fixes: #800
Before this change is applied: