macOS 13 support removed and updated docs to macOS 14 #21920

p172913 · 2025-11-18T07:00:01Z

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

macOS 13 support removed and updated macOS 13 to macOS 15 along with updated docs to macOS 14

Which issue(s) this PR fixes:
Fixes #21666

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?
None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None

k8s-ci-robot · 2025-11-18T07:00:04Z

@p172913: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

macOS 13 support removed and updated macOS 13 to macOS 15 along with updated docs to macOS 14

Which issue(s) this PR fixes:
Fixes #21666

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?
None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-11-18T07:00:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p172913
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-11-18T07:00:11Z

Hi @p172913. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

minikube-bot · 2025-11-18T07:03:03Z

Can one of the admins verify this patch?

p172913 · 2025-11-26T11:34:44Z

@nirs, @medyagh can you please review this PR...

p172913 · 2025-12-01T14:23:12Z

@nirs , @medyagh can you please review this PR...

nirs

@p172913 thanks!

nirs · 2025-12-01T21:15:00Z

.github/workflows/functional_test.yml

            driver: qemu
            cruntime: docker
-            os: macos-13
+            os: macos-15


This is wrong - macos-15 runniner is M1 which does not support virtualization, so this test will fail. We need to replace macos-13 with macos-15-intel. We don't have macos-14-intel runners.

nirs · 2025-12-01T21:16:43Z

CHANGELOG.md

 * Update Windows installer to create system-wide shortcut [#15405](https://github.com/kubernetes/minikube/pull/15405)
 * Add `--subnet` validation [#15530](https://github.com/kubernetes/minikube/pull/15530)
-* Warn users if using VirtualBox on macOS 13+ [#15624](https://github.com/kubernetes/minikube/pull/15624)
+* Warn users if using VirtualBox on macos 14+ [#15624](https://github.com/kubernetes/minikube/pull/15624)


We cannot change the changelog, remove this change.

nirs · 2025-12-01T21:17:29Z

cmd/minikube/cmd/start.go

 		return
 	}
-	out.WarningT(`Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'.
+	out.WarningT(`Due to changes in macos 14+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'.


We don't want to change this warning - it is about a change in macOS 13+ - it is still true today.

nirs · 2025-12-01T21:18:38Z

pkg/minikube/detect/detect.go

 }

-// MacOS13Plus returns if the current machine is running macOS 13+
+// MacOS13Plus returns if the current machine is running macos 14+


You change the comment but the function name is still the same. Consider changing it to MacOS14Plus() and update the version check, it should be:

major >= 14

nirs · 2025-12-01T21:20:25Z

translations/de.json

-	"Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'.\n    https://minikube.sigs.k8s.io/docs/drivers/vfkit/\n    https://minikube.sigs.k8s.io/docs/drivers/qemu/\n    https://minikube.sigs.k8s.io/docs/drivers/docker/\n    For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274\n": "",
-	"Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as docker or {{.driver}}.\n    https://minikube.sigs.k8s.io/docs/drivers/docker/\n    https://minikube.sigs.k8s.io/docs/drivers/{{.driver}}/\n\n    For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274\n": "Aufgrund von Änderungen in macOS 13+ unterstützt Minikube derzeit VirtualBox nicht. Sie können alternative Treiber verwenden, wie z.B. Docker oder {{.driver}}.\nhttps://minikube.sigs.k8s.io/docs/drivers/docker/\n    https://minikube.sigs.k8s.io/docs/drivers/{{.driver}}/\n\n    Weitere Informationen finden sich in folgendem Issue: https://github.com/kubernetes/minikube/issues/15274\n",
+	"Due to changes in macos 14+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'.\n    https://minikube.sigs.k8s.io/docs/drivers/vfkit/\n    https://minikube.sigs.k8s.io/docs/drivers/qemu/\n    https://minikube.sigs.k8s.io/docs/drivers/docker/\n    For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274\n": "",
+	"Due to changes in macos 14+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as docker or {{.driver}}.\n    https://minikube.sigs.k8s.io/docs/drivers/docker/\n    https://minikube.sigs.k8s.io/docs/drivers/{{.driver}}/\n\n    For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274\n": "Aufgrund von Änderungen in macos 14+ unterstützt Minikube derzeit VirtualBox nicht. Sie können alternative Treiber verwenden, wie z.B. Docker oder {{.driver}}.\nhttps://minikube.sigs.k8s.io/docs/drivers/docker/\n    https://minikube.sigs.k8s.io/docs/drivers/{{.driver}}/\n\n    Weitere Informationen finden sich in folgendem Issue: https://github.com/kubernetes/minikube/issues/15274\n",


Remove all the translations changes. These files will be regenerated automatically if related string in the code change.

Update support for macOS 13+ issues changed macos to macOS in translations changed macos to macOS in translations

nirs

Please address comments and squash all commit to one.

If you want to split this to multiple commit, you can split to:

GitHub workflow changes
Other changes

But this is a very small change and one commit is fine.

nirs · 2025-12-02T13:30:29Z

.github/workflows/functional_test.yml

            driver: vfkit
            cruntime: docker
-            os: macos-13
+            os: macos-15


This cannot work for vfkit for the same reason it can't work for qemu.

nirs · 2025-12-02T13:31:39Z

.github/workflows/functional_test.yml

-      - name: Ensure bootpd is enabled (macos-13)
-        if: matrix.os == 'macos-13'
+      - name: Ensure bootpd is enabled (macos-15)
+        if: matrix.os == 'macos-15'


This entire step can be removed, not needed since macOS 15

nirs · 2025-12-02T13:33:24Z

.github/workflows/functional_test.yml

          kubectl version --client=true
      - name: Install qemu and socket_vmnet (macos)
-        if: matrix.os == 'macos-13' && matrix.driver == 'qemu'
+        if: matrix.os == 'macos-15' && matrix.driver == 'qemu'


macos-15-intel

nirs · 2025-12-02T13:33:42Z

.github/workflows/functional_test.yml

          HOMEBREW=$(which brew) && sudo ${HOMEBREW} services start socket_vmnet
      - name: Install vfkit and vmnet_helper (macos)
-        if: matrix.os == 'macos-13' && matrix.driver == 'vfkit'
+        if: matrix.os == 'macos-15' && matrix.driver == 'vfkit'


macos-15-intel

nirs · 2025-12-02T13:36:33Z

.github/workflows/smoke-test.yml

Match the changes to functional tests in this file, replacing macos-13 with macos-15-intel and removing bootpd step.

nirs · 2025-12-02T13:37:05Z

cmd/minikube/cmd/start.go

 		return
 	}
-	out.WarningT(`Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'.
+	out.WarningT(`Due to changes in macos 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'.


Remove this change, the right spelling is macOS.

nirs · 2025-12-02T13:37:25Z

pkg/minikube/detect/detect.go


-// MacOS13Plus returns if the current machine is running macOS 13+
-func MacOS13Plus() bool {
+// MacOS14Plus returns if the current machine is running macos 14+


comment: macOS not macOS

function name: you rename the function, but did not change the callers of this function. Please update the callers, and if this function is not used delete the function.

nirs · 2025-12-02T13:38:45Z

CHANGELOG.md

 * Update Windows installer to create system-wide shortcut [#15405](https://github.com/kubernetes/minikube/pull/15405)
 * Add `--subnet` validation [#15530](https://github.com/kubernetes/minikube/pull/15530)
-* Warn users if using VirtualBox on macOS 13+ [#15624](https://github.com/kubernetes/minikube/pull/15624)
+* Warn users if using VirtualBox on macos 13+ [#15624](https://github.com/kubernetes/minikube/pull/15624)


remove this change, we don't change the changelog.

p172913 · 2025-12-02T18:34:48Z

Squashing commit giving merger issue with others commits. So, created new PR #22027.

macOS 13 support removed and updated docs to macOS 14

ec68a0a

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2025

k8s-ci-robot requested review from medyagh and nirs November 18, 2025 07:00

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2025

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2025

nirs suggested changes Dec 1, 2025

View reviewed changes

p172913 added 6 commits December 2, 2025 18:16

Merge branch 'kubernetes:master' into master

e130dac

Update support for macOS 13+ issues

bf7cb3f

changed macos to macOS in translations

67cd43b

changed macos to macOS in translations

ff9b2fe

Adjusted changes in translation files

4a382f4

Update support for macOS 13+ issues changed macos to macOS in translations changed macos to macOS in translations

Merge branch 'master' of https://github.com/p172913/minikube

259cbc5

nirs suggested changes Dec 2, 2025

View reviewed changes

MacOS14Plus warning resolved

0b8bd7a

p172913 closed this by deleting the head repository Dec 2, 2025

p172913 mentioned this pull request Dec 2, 2025

Revoking MacOS 13 accesses #22027

Open

macOS 13 support removed and updated docs to macOS 14 #21920

macOS 13 support removed and updated docs to macOS 14 #21920

Uh oh!

Conversation

p172913 commented Nov 18, 2025

Uh oh!

k8s-ci-robot commented Nov 18, 2025

Uh oh!

k8s-ci-robot commented Nov 18, 2025

Uh oh!

k8s-ci-robot commented Nov 18, 2025

Uh oh!

minikube-bot commented Nov 18, 2025

Uh oh!

p172913 commented Nov 26, 2025

Uh oh!

p172913 commented Dec 1, 2025

Uh oh!

nirs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

p172913 commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants