Rename log package to diagnostics#23263
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Wilson-Duncan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Wilson-Duncan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
| } | ||
| if detect.NestedVM() { | ||
| log.Debugf("Nested VM detected, increasing timeout from %s to %s", timeout, timeout*3) | ||
| diagnostics.Debugf("Nested VM detected, increasing timeout from %s to %s", timeout, timeout*3) |
There was a problem hiding this comment.
This is not a good change. Logs should use log, and we should close the issue - it is invalid. There is no issue with shadowing the standard go package since we don't use it.
This PR is for this issue #23013