Skip to content

Rename log package to diagnostics#23263

Open
Wilson-Duncan wants to merge 1 commit into
kubernetes:masterfrom
Wilson-Duncan:rename_pkg_log_to_diagnostics
Open

Rename log package to diagnostics#23263
Wilson-Duncan wants to merge 1 commit into
kubernetes:masterfrom
Wilson-Duncan:rename_pkg_log_to_diagnostics

Conversation

@Wilson-Duncan

Copy link
Copy Markdown
Contributor

This PR is for this issue #23013

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Wilson-Duncan
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot requested review from medyagh and prezha June 29, 2026 19:07
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @Wilson-Duncan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

}
if detect.NestedVM() {
log.Debugf("Nested VM detected, increasing timeout from %s to %s", timeout, timeout*3)
diagnostics.Debugf("Nested VM detected, increasing timeout from %s to %s", timeout, timeout*3)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good change. Logs should use log, and we should close the issue - it is invalid. There is no issue with shadowing the standard go package since we don't use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants