Skip to content

tool: add YAML node helpers for workflow timeout updates#23361

Open
baohuy1303 wants to merge 1 commit into
kubernetes:masterfrom
baohuy1303:yaml-node-helper
Open

tool: add YAML node helpers for workflow timeout updates#23361
baohuy1303 wants to merge 1 commit into
kubernetes:masterfrom
baohuy1303:yaml-node-helper

Conversation

@baohuy1303

Copy link
Copy Markdown
Contributor

Summary

A part of #23043

Adds a small YAML helper foundation for future workflow timeout updates.

This PR is intentionally limited to parsing and modifying YAML through yaml.Node. It does not add the timeout updater, GitHub workflow stats integration, or scheduled automation. In tests, it grabs the 1st step manually, but later PRs will make this dynamic.

What changed

  • Added ordered YAML mapping/sequence helpers:
    • Entries
    • Elements
    • Get
    • GetString
    • SetScalar
    • EncodeYAML
  • Added tests proving we can add and update timeout-minutes through YAML nodes.
  • Added tests covering comment preservation and stable key ordering for the helper behavior.
  • Moved gopkg.in/yaml.v3 to a direct dependency in the hack module.

Tests

cd hack
go test ./workflow-stats

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: baohuy1303
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @baohuy1303. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants