Update statefulset.md #48240
Update statefulset.md #48240
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks Good to me |
k8s-ci-robot
added
the
lgtm
| @@ -298,8 +298,7 @@ described [above](#deployment-and-scaling-guarantees). | |||
| `Parallel` pod management tells the StatefulSet controller to launch or | |||
| terminate all Pods in parallel, and to not wait for Pods to become Running | |||
| and Ready or completely terminated prior to launching or terminating another | |||
| Pod. This option only affects the behavior for scaling operations. Updates are not | |||
| affected. | |||
| Pod. This option only affects the behavior for scaling operations. | |||
There was a problem hiding this comment.
I don't think this change actually affects the meaning of the paragraph (it's removing a clarification). If we intended to change the meaning, I think we should do a different rewrite.
There was a problem hiding this comment.
This is indeed expected change as described in kubernetes/kubernetes#117071 and fixed in kubernetes/kubernetes#117865. With that fix we should be explicit that this operation applies to both scaling and pod creation.
There was a problem hiding this comment.
There will be followup changes after we push forward the mechanism described in kubernetes/enhancements#961 which currently blocked on monitoring requirements to be able to progress with that effort.
There was a problem hiding this comment.
This is needful as it is described in kubernetes/kubernetes#117071 and was fixed in kubernetes/kubernetes#117865 This is expected changes
There was a problem hiding this comment.
What's the difference in meaning between the two options (before and after) here?
-This option only affects the behavior for scaling operations. Updates are not affected.
+This option only affects the behavior for scaling operations.To me they have the same meaning, although the original includes a clarifying statement.
There was a problem hiding this comment.
@sftim got your point. Yes we should not ignore the last sentence as well like Updates are not affected.
The sentence is mandatory.
There was a problem hiding this comment.
Suggestions for improving this sentence
| Pod. This option only affects the behavior for scaling operations. | |
| This option only affects the behavior of scaling operations and does not impact updates. |
There was a problem hiding this comment.
I this this sentence will look more better .
There was a problem hiding this comment.
From what I have tested, this option affects updates, too. See #47085. Maybe I am not able to correctly understand what we mean by updates here.
|
Given #48240 (comment) /lgtm cancel Let's make sure we're changing meaning here. @ayushpatil2122 if you can set a short PR description that summarizes the change, it will make reviewing easier. |
k8s-ci-robot
removed
the
lgtm
I agree with Tim here, make it explicit what the current behavior is rather then implying functionality through the removal of the negation. |
|
FWIW, as an outsider, I'm still confused about the intended semantics of the The source of my confusion is the following: if neither scaling operations nor updates are constrained when |
|
@ayushpatil2122 what's your intention in terms of this PR? There is pending feedback; do you agree about revising the proposed changes? |
|
A maintainer may close this PR (due to inactivity). @ayushpatil2122 you would still be welcome to reopen it and continue work, if that had happened. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
Description
The documentation states that setting the podManagementPolicy to Parallel only affects scaling operations, not updates (like changes to the pod template). This suggests that during updates, pods should still be managed sequentially.
However, in practice, when you set podManagementPolicy to Parallel, updates are happening in parallel, meaning pods are updated without waiting for others to finish, which contradicts what the docs say.
Issue
#47085