Closed
Conversation
Member
|
I finally had a closer look into it. I can't merge it for the current version since it would break older installations. But I'll keep this open as a reminder to refactor it, in next major release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CRD will automatically deploy the
Deploymentresource and set related environment variables into the pod. However, since we're usingvalueFromto set the environment variable (Ref: https://github.com/kubero-dev/kubero-operator/blob/0b6585bd2303881644ce3ffd13f4eabc053557f5/helm-charts/kubero/templates/deployment.yaml#L73-L78), Kubernetes will actually set the value to plain text instead of base64 encoded content, so we don't need to decrypt it.Type of change
How Has This Been Tested?
I've built the image myself and tested it on my Kubernetes environment
Test Configuration:
Checklist: