Skip to content

Fix User Authentication Error#374

Closed
FawenYo wants to merge 1 commit intokubero-dev:mainfrom
FawenYo:fix/fix_user_auth
Closed

Fix User Authentication Error#374
FawenYo wants to merge 1 commit intokubero-dev:mainfrom
FawenYo:fix/fix_user_auth

Conversation

@FawenYo
Copy link
Copy Markdown

@FawenYo FawenYo commented Jun 28, 2024

Description

The CRD will automatically deploy the Deployment resource and set related environment variables into the pod. However, since we're using valueFrom to set the environment variable (Ref: https://github.com/kubero-dev/kubero-operator/blob/0b6585bd2303881644ce3ffd13f4eabc053557f5/helm-charts/kubero/templates/deployment.yaml#L73-L78), Kubernetes will actually set the value to plain text instead of base64 encoded content, so we don't need to decrypt it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I've built the image myself and tested it on my Kubernetes environment

image

Test Configuration:

  • OS with version: Kubernetes 1.30.1
  • Browser with version:
  • SDK / CLI with version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mms-gianni
Copy link
Copy Markdown
Member

I finally had a closer look into it. I can't merge it for the current version since it would break older installations.

But I'll keep this open as a reminder to refactor it, in next major release.

@mms-gianni mms-gianni added the on hold do not merge, waiting label Jul 20, 2024
@mms-gianni mms-gianni closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold do not merge, waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants