chore: bump kubescape/storage to v0.0.305 - #61
Merged
Conversation
storage v0.0.303 (kubescape/storage#351) removed the ApplicationProfile and NetworkNeighborhood CRD types in favor of the unified ContainerProfile type. The backend's gRPC API still serves these types on the wire for backward compatibility with existing clients, so this vendors their shape - field-for-field, tag-for-tag, from storage v0.0.302 (the last version that defined them) - into a new pkg/apis/softwarecomposition/v1beta1 package. Sub-types storage still exports (ExecCalls, OpenCalls, HTTPEndpoint, RulePolicy, IdentifiedCallStack, SingleSeccompProfile, NetworkNeighbor) are reused from the storage package rather than duplicated. storage_service.proto/.pb.go now reference the vendored types for the application_profile/network_neighborhood fields while ContainerProfile and SBOMSyft keep coming from storage. Verified the real gRPC codec round-trips these types correctly (GetProfile/ListApplicationProfiles through an actual grpc.Server+ClientConn over bufconn), not just the mocked unit tests.
matthyx
added
the
ai-assisted
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
supersedes #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/kubescape/storagetov0.0.305.ApplicationProfileandNetworkNeighborhoodCRD types in favor of the unifiedContainerProfiletype. The backend's gRPC API still exposes these types on the wire for backward compatibility with existing clients (node-agent, etc.), so this PR vendors their shape back into the backend atpkg/apis/softwarecomposition/v1beta1.v0.0.302(the last version that defined them), including the hand-adapted gogo-protoMarshal/Unmarshal/Size/Stringimplementations, so the wire format is unchanged for existing clients. Sub-types storage still exports (ExecCalls,OpenCalls,HTTPEndpoint,RulePolicy,IdentifiedCallStack,SingleSeccompProfile,NetworkNeighbor) are reused directly from the storage package rather than duplicated.storage_service.proto/.pb.gonow reference the vendored types for theapplication_profile/network_neighborhoodfields, whileContainerProfileandSBOMSyftcontinue to come fromstorage. Addedlegacy_softwarecomposition.protopurely as IDL documentation of the vendored wire shape (it is intentionally not wired intomake proto— see its header comment for why).Test plan
go build ./...go vet ./...go test ./...(all packages pass)grpc.Server/grpc.ClientConnoverbufconnand round-trippedGetProfileandListApplicationProfilesresponses containing nested fields (Execs,PolicyByRuleId, etc.)AI-skills: none