feat: Improve SELECT DISTINCT formatting, #11
Open
antimirov wants to merge 1 commit intokufii:masterfrom
Open
Conversation
…STINCT affects all columns, not just the first one
leandroluk
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve SELECT DISTINCT formatting, making it clear that the DISTINCT affects all columns, not just the first one. An example SQL style guide - https://about.gitlab.com/handbook/business-technology/data-team/platform/sql-style-guide/
Unformatted code:
Current behavior:
Suggested new behavior:
Notice, that even Github's markdown highlighter works better with the last example, marking
SELECT DISTINCTas keywords. In the current behavior the pairDISTINCT supplier_nameis shown in gray color.