chore: MultiComboBoxの内部処理を整理する #5338
Open
+232
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-add-use-decorators
yagimushi
force-pushed
the
chore-refactoring-MultiComboBox
branch
from
a7fbd27 to
8eddda4
Compare
commit: |
…e-add-use-decorators
…e-refactoring-MultiComboBox
…e-refactoring-MultiComboBox
…e-refactoring-MultiComboBox
…e-refactoring-MultiComboBox
AtsushiM
commented
Feb 25, 2025
| onSelect?.(selected) | ||
| onChangeSelected?.(selectedItems.concat(selected)) | ||
| } else if (matchedSelectedItem.deletable !== false) { | ||
| handleDelete(selected) |
There was a problem hiding this comment.
条件分岐を整理し、ネストが不要な状態にしています。
AtsushiM
commented
Feb 25, 2025
| !disabled && | ||
| !isFocused | ||
| !isFocused && | ||
| !(e.target as HTMLElement).closest('.smarthr-ui-MultiComboBox-deleteButton') |
There was a problem hiding this comment.
hasParentElementByClassName はdomに対する検索になるため、他の条件と比べてかなり低速です。
そのため、まず他条件を調べてから必要な場合のみ実行するようにしています。
またhasParentElementByClassNameはやっている内容がほぼbuildinのclosestと同じ内容のため置き換えています
AtsushiM
commented
Feb 25, 2025
| @@ -376,7 +368,7 @@ const ActualMultiComboBox = <T,>( | |||
| const handleCompositionStartInput = useCallback(() => setIsComposing(true), []) | |||
| const handleCompositionEndInput = useCallback(() => setIsComposing(false), []) | |||
| const handleInputKeyDown = useCallback((e: KeyboardEvent<HTMLInputElement>) => { | |||
| if (e.key === 'Down' || e.key === 'ArrowDown' || e.key === 'Up' || e.key === 'ArrowUp') { | |||
| if (ARROW_UP_AND_DOWN_KEY_REGEX.test(e.key)) { | |||
There was a problem hiding this comment.
複雑なifでしたが、完全に同じ値に対するチェックだったため、正規表現一発に置き換えています
AtsushiM
requested review from
s-sasaki-0529 and
masa0527
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法