chore: Badge, Balloon, Base, BaseColumn, CurrencyInputの内部処理を最適化する #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
changed the title
AtsushiM
commented
Feb 3, 2025
| import { useClassNameGenerator } from '../../hooks/useClassNameGenerator' | ||
|
|
||
| export function useClassNames() { | ||
| const generate = useClassNameGenerator('Balloon') |
There was a problem hiding this comment.
やっていることは一定のclassNameを生成することだけであり、他コンポーネントではベタ打ちでコンポーネントに記述されているため、このhook自体を削除しました。
対象はBalloonとCurrencyInputになります
There was a problem hiding this comment.
そもそもBalloonは未使用のhookから呼び出されているだけでした
AtsushiM
requested review from
oti and
s-sasaki-0529
and removed request for
a team
yagimushi
force-pushed
the
chore-refactoring-Base
branch
from
6bb6154 to
bec13da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法