Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: AppHeaderのカスタムフック系の処理を最適化する #5351

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

chore: AppHeaderのカスタムフック系の処理を最適化する #5351

wants to merge 11 commits into from
+72 −65

Conversation

AtsushiM
Copy link
Member

関連URL

概要

変更内容

確認方法

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 31, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5351

commit: 5cdcedb

@yagimushi yagimushi force-pushed the chore-refactoring-AppHeader branch from 57d0be7 to 5cdcedb Compare February 12, 2025 23:43
@AtsushiM AtsushiM marked this pull request as ready for review February 18, 2025 22:08
@AtsushiM AtsushiM requested a review from a team as a code owner February 18, 2025 22:08
@AtsushiM AtsushiM requested review from oti and uknmr and removed request for a team February 18, 2025 22:08
oti
oti approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@oti oti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 姓名って両方揃ってないと出てこなかったんですね〜（そりゃそうか）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oti oti oti approved these changes

@uknmr uknmr Awaiting requested review from uknmr uknmr is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtsushiM @oti