chore: StatusLabel, SpreadsheetTable, SmartHRLogoの内部処理を整理する #5378
+115
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
fix-format-StatusLabel
branch
from
0b427d5 to
670635a
Compare
commit: |
yagimushi
force-pushed
the
fix-format-StatusLabel
branch
from
670635a to
2be4274
Compare
yagimushi
force-pushed
the
fix-format-StatusLabel
branch
3 times, most recently
from
8e136fe to
4f21f6e
Compare
yagimushi
force-pushed
the
fix-format-StatusLabel
branch
from
4f21f6e to
63652bc
Compare
AtsushiM
commented
Feb 14, 2025
| return <FaCircleExclamationIcon /> | ||
| } | ||
| } | ||
| export const StatusLabel = memo<Props>( |
There was a problem hiding this comment.
StatusLable自体が再レンダリングする必要性がほぼないコンポーネントのため、全体をmemo化しています
AtsushiM
commented
Feb 14, 2025
|
|
||
| export const SpreadsheetTableCorner = () => ( | ||
| export const SpreadsheetTableCorner = memo(() => ( |
There was a problem hiding this comment.
SpreadsheetTableCorner 自体が引数が一切ない、装飾用コンポーネントのためmemoで提供します
AtsushiM
commented
Feb 14, 2025
| @@ -63,3 +59,27 @@ export const SpreadsheetTable: React.FC<Props & ElementProps> = ({ | |||
| </table> | |||
| ) | |||
| } | |||
|
|
|||
| const MemoizedThead = memo<{ cols: number }>(({ cols }) => { | |||
There was a problem hiding this comment.
引数一つでTheadをまるごとmemo化でき、かつ再レンダリングが必要になる可能性も低いためmemo化状態で提供します
AtsushiM
commented
Feb 14, 2025
Comment on lines
+48
to
+51
| <tr key={i}> | ||
| <th>{i + 1}</th> | ||
| {row.map((cell, j) => ( | ||
| <td key={`bodyCell-${i}-${j}`}>{cell}</td> | ||
| <td key={`${i}-${j}`}>{cell}</td> |
There was a problem hiding this comment.
ループ中でダブらないkeyにできればいいため、余計なテキストとの結合をやめます
AtsushiM
commented
Feb 14, 2025
| }), | ||
| [className, fill, height, width], | ||
| ) | ||
| export const SmartHRLogo = memo<Props & ElementProps>( |
There was a problem hiding this comment.
Logoは一度レンダリングすれば、再レンダリングが必要になる可能性が低いため、丸ごとmemoしています
AtsushiM
requested review from
Qs-F and
s-sasaki-0529
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法