chore: AppHeader/mobileの内部ロジックを整理する vol.2 #5393
Open
+179
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-AppHeader-mobile-vol2
branch
from
d37eb0f to
fe3b10e
Compare
commit: |
yagimushi
force-pushed
the
chore-refactoring-AppHeader-mobile-vol2
branch
from
fe3b10e to
6341b21
Compare
AtsushiM
commented
Feb 18, 2025
| @@ -78,7 +78,7 @@ export const MenuDialog: FC< | |||
| onClickBack={() => setIsReleaseNoteSelected(false)} | |||
| /> | |||
| ) : selectedNavigationGroup ? ( | |||
| <NavigationGroupHeader currentNavigationGroup={selectedNavigationGroup} /> | |||
| <NavigationGroupHeader title={selectedNavigationGroup.children} /> | |||
There was a problem hiding this comment.
必要最小限の値のみ渡すことでmemoの効率を良くします
AtsushiM
requested review from
Qs-F and
hiroki0525
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法