chore: テキスト系のシンプルなコンポーネントをmemo化する #5406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
fix-memoized-simple-component
branch
from
bcbc89a to
254cc97
Compare
yagimushi
force-pushed
the
fix-memoized-simple-component
branch
from
254cc97 to
8ef3027
Compare
commit: |
AtsushiM
commented
Feb 24, 2025
| } | ||
|
|
||
| export const Text = memo(ActualText) as typeof ActualText |
There was a problem hiding this comment.
genericsを使ったコンポーネントをmemo化する場合、asで明確に型付けし直すことで問題なく設定できます。
https://www.google.com/search?q=typescript+generics+memo&oq=typescript+generics+memo&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIHCAEQABjvBTIHCAIQABjvBTIHCAMQABjvBTIHCAQQABjvBTIHCAUQABjvBdIBCDkyMjhqMGo3qAIAsAIA&sourceid=chrome&ie=UTF-8
AtsushiM
commented
Feb 24, 2025
|
|
||
| return ( | ||
| <div className={style}> | ||
| <TextLink {...rest} elementAs={elementAs} prefix={<FaArrowLeftIcon />} /> |
There was a problem hiding this comment.
elementAsが消えているように見えますが、https://github.com/kufu/smarthr-ui/pull/5406/files#diff-5f096a050e1946adb3b1a45c9737159ebceea44f39788f072ea5b19eee4385baR23 でrestに含めるようにしているため、指定としては同じ状態になっています
AtsushiM
commented
Feb 24, 2025
| import { tv } from 'tailwind-variants' | ||
|
|
||
| export const visuallyHiddenText = tv({ | ||
| export const visuallyHiddenTextClassNameGenerator = tv({ |
There was a problem hiding this comment.
visuallyHiddenText ではコンポーネントと区別がつきにくいため、明確にしました。
長くてちょっと...とも思いますが基本的にsmarthr-ui内に隠蔽される概念のため、空目・typoよりはマシかと...
AtsushiM
requested review from
moshisora and
nabeliwo
and removed request for
a team
…memoized-simple-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法