chore: useSectionWrapperのロジックを調整 #5411
Open
+98
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
yagimushi
force-pushed
the
fix-useSectionWrapper
branch
3 times, most recently
from
224f80c to
5dc79a7
Compare
yagimushi
force-pushed
the
fix-useSectionWrapper
branch
from
5dc79a7 to
d51fc61
Compare
AtsushiM
commented
Feb 25, 2025
| <Component {...props} ref={ref} className={styles} /> | ||
| </Wrapper> | ||
| ) | ||
| if (Wrapper) { |
There was a problem hiding this comment.
React.Fragmentの実行は単純なdivをレンダリングするより重いらしく、条件分岐することにしました。
元のロジックでは常になにか処理が必要な印象を受けてしまうので、 必要な場合のみ であることがわかるというメリットもあります
| @@ -5,14 +5,15 @@ import { SectioningFragment } from './SectioningContent' | |||
|
|
|||
| type ComponentType = string | React.ComponentType<any> | |||
|
|
|||
| const sectioningContents = ['article', 'aside', 'nav', 'section'] | |||
| const SECTIONING_CONTENTS_REGEX = /^(article|aside|nav|section)$/ | |||
There was a problem hiding this comment.
配列をチェックするより、正規表現一発でやるほうが早いため切り替えました
AtsushiM
requested review from
oti and
yuzuru-akiyama
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法