chore: Stepperのmarkupを整える #5418
Open
+33
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
commented
Feb 28, 2025
Comment on lines
-102
to
+108
| <Heading type="sectionTitle" className={classNames.heading}> | ||
| {label} | ||
| </Heading> | ||
| <div className={classNames.labelWrapper}> | ||
| <div className={classNames.stepCounterWrapper}> | ||
| <span className={classNames.beforeLine} /> | ||
| <StepCounter status={status} current={current} stepNumber={stepNumber} /> | ||
| <span className={classNames.afterLine} /> | ||
| </div> | ||
| </SectioningFragment> | ||
| <Text styleType="sectionTitle" className={classNames.label}> | ||
| {label} | ||
| </Text> |
There was a problem hiding this comment.
Headingの内容に当たるものがHorizontal(横方向)のStepperには存在しないため、Textに変更しました
AtsushiM
commented
Feb 28, 2025
| @@ -74,7 +74,7 @@ export const VerticalStepItem: FC<Props> = ({ stepNumber, label, status, childre | |||
|
|
|||
| return ( | |||
| <li aria-current={current ? 'step' : undefined} className={classNames.wrapper}> | |||
| <SectioningFragment> | |||
| <Section> | |||
There was a problem hiding this comment.
liごとに暗黙のoutlineが切られることになるため、このままでも大きな問題にはなりません。
が、実用上SectioningFragmentとSectionでレンダリングコストがほぼ変わらないこと、テストを書く際の within_section のように特定の構造に対するテストなどが書きづらいため、Sectionに変更しました
AtsushiM
requested review from
misako0927 and
nabeliwo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法