fix(Fieldset): innerMarginとして0.5を受け取れるように修正 #5421
Open
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qs-F
requested review from
oti and
yuzuru-akiyama
and removed request for
a team
commit: |
|
[HINT] VRTでの差分はinnerMarginが0.5が指定されていても1があたってしまっていたところを修正しているものなのでacceptでいいはずです |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://kufuinc.slack.com/archives/CGC58MW01/p1740726417428149
概要
Fieldsetが innerMarginとして
0.5を受け取れなくなっていたので修正変更内容
1を指定するように修正確認方法
1であることを確認 https://63d0ccabb5d2dd29825524ab-yjibkvwsnc.chromatic.com/?path=/story/forms%EF%BC%88%E3%83%95%E3%82%A9%E3%83%BC%E3%83%A0%EF%BC%89-fieldset--playground (VRTでOK)