🎨Clean up the next link parser#193
Open
bvanderlaan wants to merge 1 commit intokwk:v2from
Open
Conversation
Per the TODO _Can we clean this up a bit?_ this change set cleans up the code used to parse out the last value via the next link header. In the current implementation we use substring, indexOf, and replace which results in a bit of nesting and unclear code. This change set updates that code to use Regular Expressions and named functions to make the code more clear. Tests were added to ensure hat this refactor didn't break anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the
TODO: Can we clean this up a bit?this change set cleans upthe code used to parse out the last value via the next link header.
In the current implementation we use substring, indexOf, and replace
which results in a bit of nesting and unclear code. This change set
updates that code to use Regular Expressions and named functions to
make the code more clear.
Tests were added to ensure hat this refactor didn't break anything