-
Notifications
You must be signed in to change notification settings - Fork 243
[master branch] add gosu and refactor things #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robbyoconnor
wants to merge
1
commit into
kylemanna:master
Choose a base branch
from
robbyoconnor:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46fdb5c
to
e258b67
Compare
robbyoconnor
commented
Jul 18, 2017
@@ -3,22 +3,34 @@ | |||
# | |||
FROM ubuntu:16.04 | |||
|
|||
MAINTAINER Kyle Manna <[email protected]> | |||
LABEL maintainer "Kyle Manna <[email protected]>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way to do things now
4c30100
to
677a799
Compare
543f373
to
24a41ca
Compare
Open
95e8f7b
to
ef1ae9b
Compare
Also rebased this. |
I nuked sudo as a package dependency. gosu is sufficient for this. |
@kylemanna ready for showtime on both this and #31 -- tested both |
912e01a
to
08ce33a
Compare
87286bf
to
f3cd20a
Compare
78b0047
to
7117279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #31 -- but forward-ported to
master
-- I'm working on a MM ROM so using that branch.