Skip to content

feat: fips140 compliant image #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: fips140 compliant image #2120

wants to merge 11 commits into from

Conversation

a-thaler
Copy link
Collaborator

@a-thaler a-thaler commented May 14, 2025 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler requested a review from a team as a code owner May 14, 2025 15:49
@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/manager Manager or module changes labels May 14, 2025
@github-actions github-actions bot added this to the 1.41.0 milestone May 14, 2025
@shorim shorim modified the milestones: 1.41.0, 1.42.0 May 27, 2025
k15r
k15r reviewed Jun 2, 2025
View reviewed changes
internal/webhookcert/ca_cert_generator.go
@@ -48,6 +50,20 @@ func (g *caCertGeneratorImpl) generateCertInternal() (*x509.Certificate, *rsa.Pr
validFrom := g.clock.now().Add(-time.Hour).UTC() // valid an hour earlier to avoid flakes due to clock skew
validTo := validFrom.Add(caCertMaxAge).UTC()

pub := caKey.Public()

icke, ok := pub.(rsa.PublicKey)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@a-thaler a-thaler added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/manager Manager or module changes do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
3 participants
@a-thaler @k15r @shorim