fix(smoke): pin COLUMNS=200 so Rich wrapping can't split grepped phrases - #110
Merged
Conversation
Non-tty runs default Rich to 80 columns, which wrapped 'no occurrence records' across lines and failed the trace-citation check in smoke_test.sh despite correct CLI output. Pin a wide width in all smoke scripts so every phrase-grep is deterministic regardless of terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background (non-tty) smoke runs default Rich to 80 columns; the trace-citation check in
smoke_test.shfailed because the phrase "no occurrence records" wrapped mid-phrase, even though the CLI output was correct. Every phrase-grep in the smoke scripts is exposed to the same wrap-point luck.Fix: export
COLUMNS=200(Rich honors it) right after thesetline in all 8 shell smoke scripts, making grep checks deterministic regardless of terminal width.Verified:
Console().widthis 80 piped / 200 with the export; the failing phrase stays contiguous.