Upload traces directly to Github. Corrections to PR361 #460
Conversation
…position fix is obtained After the SDK update, UI buttons for marking waypoints remained disabled even after an accurate fix was acquired. This fix ensures that the UI buttons are enabled as soon as an accurate fix is confirmed, improving user experience in "hot start" situations.
… a temporary file path - Modified `uploadTrackToGitHubAUX` to save the GPX file in Base64 to internal storage and pass only the file path in the Intent instead of the full content. - Updated `GitHubUpload` to read the GPX file from the provided path, avoiding large Bundles. - Added error handling for GPX file reading, displaying a message if reading fails. This change prevents oversized Bundle errors and optimizes data transfer between activities.
|
This functionality allows you to upload a trace with a unique name to GitHub. If a trace with the same name already exists in the repository, OSMTracker will not update the file. |
Merge pull request labexp#516 from labexp/develop
Standardized pull request template to improve consistency in PR submissions. - Includes sections for description, related issues, and a checklist. - Ensures contributors provide relevant details for better review
Added a bug report template to ensure users provide a clear description, reproduction steps, and device details. Includes a checklist to prevent duplicate reports.
Added a configuration file to enable blank issues and direct questions to GitHub Discussions.
There was a problem hiding this comment.
✅ Tested and works as expected.
I tested this PR on the latest develop branch. The feature successfully uploads the GPX trace along with its associated media files (photos and audio) as a ZIP archive to GitHub.
The app avoids overwriting files with the same name and handles large traces properly without crashes.
Everything works smoothly. Great improvement for collaborative mapping workflows!
|
Hello! @Andyporras 👋🏻 |
|
@miltonials yes, unnecessary comments have already been deleted |
Hi @Binnette! I have checked PR#361 (WIP - New feature: Upload traces directly to Github) using the current state of the develop branch. The PR works fine, but I have found a problem when the trace size is too large, I have fixed this bug and a conflict in this PR.
I will appreciate if you have some suggestions to implement these fixes. If the new functionality is implemented, I may update the wiki to put the usage instructions for this new functionality.
Remark: the new functionality (pr#361) needs a classic gh token, instead of a fine-granuled token.
This PR is related to
#344
#361
Commits
Special thanks to @FR3DD221 for helping me find issues of the PR#361.