Skip to content

Conversation

@steelman
Copy link

@steelman steelman commented Nov 6, 2025

Add missing return in get_output() to propagate value returned by a device specific function.

Fixes: 7ab6240 ("util/agents/usb_hid_relay: fix concurrent access")

@Emantor
Copy link
Member

Emantor commented Nov 7, 2025

Code looks good, please add the missing DCO.

@steelman
Copy link
Author

steelman commented Nov 8, 2025

It's there in the commit message.

EDIT: updated.

@steelman steelman force-pushed the usb-hid-relay branch 2 times, most recently from 5b13e1c to 747f499 Compare November 14, 2025 15:05
@steelman
Copy link
Author

Ping?

Add missing return in get_output() to propagate value returned
by a device specific function.

Fixes: 7ab6240 ("util/agents/usb_hid_relay: fix concurrent access")
Signed-off-by: Łukasz Stelmach <[email protected]>
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.2%. Comparing base (70f6150) to head (5de1be1).
⚠️ Report is 10 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/util/agents/usb_hid_relay.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1768   +/-   ##
======================================
  Coverage    45.2%   45.2%           
======================================
  Files         172     172           
  Lines       13569   13569           
======================================
  Hits         6136    6136           
  Misses       7433    7433           
Flag Coverage Δ
3.10 45.2% <0.0%> (ø)
3.11 45.2% <0.0%> (ø)
3.12 45.2% <0.0%> (ø)
3.13 45.1% <0.0%> (ø)
3.14 45.1% <0.0%> (ø)
3.9 45.2% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Emantor Emantor merged commit d4dafb9 into labgrid-project:master Nov 25, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants