Skip to content

Support Multiple virtual dbs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions labml_db/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@


class Index(Generic[_KT]):
__db_drivers: Dict[str, IndexDbDriver]
__db_drivers: Dict[str, IndexDbDriver] = {}

@staticmethod
def set_db_drivers(db_drivers: List[IndexDbDriver]):
Index.__db_drivers = {d.index_name: d for d in db_drivers}
for d in db_drivers:
Index.__db_drivers[d.index_name] = d

@classmethod
def delete(cls, index_key: str):
Expand Down Expand Up @@ -41,3 +42,9 @@ def mget(cls, index_key: List[str]) -> List[Optional[Key[_KT]]]:
def set(cls, index_key: str, model_key: Key[_KT]):
db_driver = Index.__db_drivers[cls.__name__]
db_driver.set(index_key, str(model_key))

@classmethod
def get_all(cls):
db_driver = Index.__db_drivers[cls.__name__]
keys = db_driver.get_all()
return keys
3 changes: 3 additions & 0 deletions labml_db/index_driver/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ def mget(self, index_key: List[str]) -> List[str]:

def set(self, index_key: str, model_key: str):
raise NotImplementedError

def get_all(self) -> List[str]:
raise NotImplementedError
4 changes: 3 additions & 1 deletion labml_db/index_driver/redis.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ def get(self, index_key: str) -> str:
def mget(self, index_key: List[str]) -> List[str]:
return self._db.hmget(self._index_key, index_key)


def set(self, index_key: str, model_key: str):
self._db.hset(self._index_key, index_key, model_key)

def get_all(self):
return self._db.hgetall(self._index_key)
5 changes: 3 additions & 2 deletions labml_db/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def defaults(self) -> Dict[str, Primitive]:

class Model(Generic[_KT]):
__models: Dict[str, ModelSpec] = {}
__db_drivers: Dict[str, 'DbDriver']
__db_drivers: Dict[str, 'DbDriver'] = {}
_defaults = Dict[str, Primitive]
_values = Dict[str, Primitive]

Expand Down Expand Up @@ -239,7 +239,8 @@ def key(self) -> 'Key[_KT]':

@staticmethod
def set_db_drivers(db_drivers: List['DbDriver']):
Model.__db_drivers = {d.model_name: d for d in db_drivers}
for d in db_drivers:
Model.__db_drivers[d.model_name] = d

@classmethod
def mread_dict(cls, key: List[str], db_driver: Optional['DbDriver'] = None) -> List[ModelDict]:
Expand Down