Avoid installing gmp when executing `install-macos.sh` #2063

FrancoGiachetta · 2025-04-07T20:37:35Z

Add a check in install-macos.sh to see if gmp is already installed

Description

Description of the pull request changes and motivation.

Checklist

Linked to Github Issue
Unit tests added
Integration tests added.
This change requires new documentation.
- Documentation has been added/updated.
- CHANGELOG has been updated.

github-actions · 2025-04-07T20:46:22Z

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.410 s ±  0.032 s    [User: 25.579 s, System: 0.828 s]
  Range (min … max):   26.388 s … 26.433 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.407 s ±  0.028 s    [User: 25.584 s, System: 0.820 s]
  Range (min … max):   26.387 s … 26.427 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.677 s ±  0.066 s    [User: 25.692 s, System: 0.811 s]
  Range (min … max):   14.630 s … 14.723 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.681 s ±  0.034 s    [User: 25.644 s, System: 0.856 s]
  Range (min … max):   14.657 s … 14.705 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.520 s ±  0.314 s    [User: 37.655 s, System: 1.009 s]
  Range (min … max):   10.298 s … 10.742 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.485 s ±  0.302 s    [User: 37.638 s, System: 1.006 s]
  Range (min … max):   10.272 s … 10.698 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.00 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.341 s ±  0.154 s    [User: 37.776 s, System: 0.997 s]
  Range (min … max):   10.232 s … 10.450 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.363 s ±  0.289 s    [User: 38.036 s, System: 1.017 s]
  Range (min … max):   10.159 s … 10.567 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.00 ± 0.03 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.488 s ±  0.064 s    [User: 37.817 s, System: 1.059 s]
  Range (min … max):   10.443 s … 10.533 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.344 s ±  0.139 s    [User: 38.064 s, System: 1.050 s]
  Range (min … max):   10.246 s … 10.443 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.452 s ±  0.289 s    [User: 38.371 s, System: 1.125 s]
  Range (min … max):   10.248 s … 10.656 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.397 s ±  0.298 s    [User: 38.416 s, System: 1.132 s]
  Range (min … max):   10.186 s … 10.608 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.04 times faster than hyper_threading_main threads: 16

github-actions · 2025-04-07T20:55:15Z

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_factorial`	2.124 ± 0.009	2.114	2.139	1.00 ± 0.00
`head big_factorial`	2.116 ± 0.003	2.111	2.121	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_fibonacci`	2.043 ± 0.007	2.037	2.056	1.00 ± 0.00
`head big_fibonacci`	2.037 ± 0.006	2.029	2.047	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base blake2s_integration_benchmark`	7.535 ± 0.094	7.478	7.797	1.01 ± 0.01
`head blake2s_integration_benchmark`	7.493 ± 0.021	7.468	7.524	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base compare_arrays_200000`	2.176 ± 0.012	2.165	2.206	1.00
`head compare_arrays_200000`	2.182 ± 0.020	2.168	2.231	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_integration_benchmark`	1.425 ± 0.014	1.416	1.463	1.00
`head dict_integration_benchmark`	1.427 ± 0.005	1.419	1.436	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base field_arithmetic_get_square_benchmark`	1.223 ± 0.014	1.211	1.256	1.01 ± 0.01
`head field_arithmetic_get_square_benchmark`	1.213 ± 0.004	1.206	1.219	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base integration_builtins`	7.587 ± 0.022	7.542	7.615	1.00 ± 0.01
`head integration_builtins`	7.572 ± 0.034	7.523	7.616	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base keccak_integration_benchmark`	7.831 ± 0.027	7.805	7.884	1.00
`head keccak_integration_benchmark`	7.859 ± 0.050	7.810	7.993	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base linear_search`	2.173 ± 0.012	2.156	2.201	1.00
`head linear_search`	2.174 ± 0.012	2.162	2.199	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_cmp_and_pow_integration_benchmark`	1.522 ± 0.006	1.513	1.534	1.00 ± 0.00
`head math_cmp_and_pow_integration_benchmark`	1.520 ± 0.003	1.515	1.524	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_integration_benchmark`	1.464 ± 0.003	1.460	1.470	1.00
`head math_integration_benchmark`	1.472 ± 0.015	1.462	1.514	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base memory_integration_benchmark`	1.222 ± 0.004	1.219	1.229	1.00
`head memory_integration_benchmark`	1.225 ± 0.003	1.222	1.231	1.00 ± 0.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base operations_with_data_structures_benchmarks`	1.578 ± 0.005	1.571	1.590	1.00
`head operations_with_data_structures_benchmarks`	1.584 ± 0.007	1.574	1.596	1.00 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base pedersen`	534.2 ± 1.3	532.2	535.8	1.00
`head pedersen`	534.7 ± 1.8	532.5	537.5	1.00 ± 0.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base poseidon_integration_benchmark`	642.8 ± 3.5	639.1	651.8	1.00 ± 0.01
`head poseidon_integration_benchmark`	642.7 ± 2.8	638.6	647.3	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base secp_integration_benchmark`	1.888 ± 0.052	1.860	2.029	1.01 ± 0.03
`head secp_integration_benchmark`	1.870 ± 0.005	1.863	1.882	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base set_integration_benchmark`	630.1 ± 3.0	626.4	637.6	1.00 ± 0.01
`head set_integration_benchmark`	629.2 ± 1.3	627.2	631.0	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base uint256_integration_benchmark`	4.194 ± 0.069	4.146	4.377	1.00 ± 0.02
`head uint256_integration_benchmark`	4.191 ± 0.035	4.171	4.286	1.00

codecov · 2025-04-07T21:04:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (3b36cd9) to head (933f4fd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2063   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         102      102           
  Lines       42924    42924           
=======================================
  Hits        41456    41456           
  Misses       1468     1468

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JulianGCalderon · 2025-04-30T21:24:53Z

install-scripts/install-macos.sh

+if ! type foobar &> /dev/null; then
+    brew install gmp
+fi


What is type foobar?

Maybe we can do:

brew install --force gmp

Instead of checking if it exists.

Waiting for this conversation to be resolved

avoid installing gmp if it is already installed

1baaec8

FrancoGiachetta added the pipelines This PR/issue is exclusively about improving our CI label Apr 7, 2025

FrancoGiachetta changed the title ~~Avoid installing gmp when executing install-macos.sh~~ Avoid installing gmp when executing install-macos.sh Apr 7, 2025

FrancoGiachetta added 4 commits April 7, 2025 18:06

fix

8182981

fix if

983ec2e

Merge branch 'main' into avoid-reinstall-gmp

7c15f64

Merge branch 'main' into avoid-reinstall-gmp

33cddca

FrancoGiachetta marked this pull request as ready for review April 15, 2025 12:53

Merge branch 'main' into avoid-reinstall-gmp

933f4fd

gabrielbosio linked an issue Apr 30, 2025 that may be closed by this pull request

CI: gmp already installed warning #2058

Open

gabrielbosio previously approved these changes Apr 30, 2025

View reviewed changes

JulianGCalderon reviewed Apr 30, 2025

View reviewed changes

gabrielbosio self-requested a review April 30, 2025 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid installing gmp when executing `install-macos.sh` #2063

Avoid installing gmp when executing `install-macos.sh` #2063

FrancoGiachetta commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

codecov bot commented Apr 7, 2025 •

edited

Loading

JulianGCalderon Apr 30, 2025

JulianGCalderon Apr 30, 2025

Avoid installing gmp when executing install-macos.sh #2063

Are you sure you want to change the base?

Avoid installing gmp when executing install-macos.sh #2063

Conversation

FrancoGiachetta commented Apr 7, 2025 • edited Loading

Add a check in install-macos.sh to see if gmp is already installed

Description

Checklist

github-actions bot commented Apr 7, 2025 • edited Loading

github-actions bot commented Apr 7, 2025 • edited Loading

codecov bot commented Apr 7, 2025 • edited Loading

Codecov Report

JulianGCalderon Apr 30, 2025

Choose a reason for hiding this comment

JulianGCalderon Apr 30, 2025

Choose a reason for hiding this comment

Avoid installing gmp when executing `install-macos.sh` #2063

Avoid installing gmp when executing `install-macos.sh` #2063

FrancoGiachetta commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

codecov bot commented Apr 7, 2025 •

edited

Loading